Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish scaledensity_norm deprecation #3244

Merged
merged 5 commits into from
Sep 20, 2024
Merged

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Sep 20, 2024

sc.pl.violin and sc.pl.stacked_violin were missed in #2844

@flying-sheep flying-sheep changed the title Fix density_norm deprecation Fix scaledensity_norm deprecation Sep 20, 2024
@flying-sheep flying-sheep changed the title Fix scaledensity_norm deprecation Finish scaledensity_norm deprecation Sep 20, 2024
@flying-sheep flying-sheep added this to the 1.10.4 milestone Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.77%. Comparing base (bd75839) to head (32279bf).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3244      +/-   ##
==========================================
+ Coverage   76.49%   76.77%   +0.27%     
==========================================
  Files         109      109              
  Lines       12544    12550       +6     
==========================================
+ Hits         9596     9635      +39     
+ Misses       2948     2915      -33     
Files with missing lines Coverage Δ
src/scanpy/plotting/_anndata.py 85.02% <100.00%> (+0.03%) ⬆️
src/scanpy/plotting/_stacked_violin.py 84.57% <100.00%> (ø)
src/scanpy/plotting/_tools/__init__.py 77.60% <100.00%> (ø)
src/scanpy/plotting/_utils.py 56.56% <100.00%> (+0.32%) ⬆️

... and 2 files with indirect coverage changes

@flying-sheep flying-sheep merged commit b0597a9 into main Sep 20, 2024
18 of 22 checks passed
@flying-sheep flying-sheep deleted the fix-scale-deprecation branch September 20, 2024 10:34
meeseeksmachine pushed a commit to meeseeksmachine/scanpy that referenced this pull request Sep 20, 2024
flying-sheep added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants