Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release note building and check #3239

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Fix release note building and check #3239

merged 4 commits into from
Sep 17, 2024

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Sep 17, 2024

See https://setuptools-scm.readthedocs.io/en/latest/extending/#setuptools_scmversion_scheme:

Semantic versioning for projects with release branches. The same as guess-next-dev (incrementing the pre-release or micro segment) however when on a release branch: a branch whose name (ignoring namespace) parses as a version that matches the most recent tag up to the minor segment. Otherwise if on a non-release branch, increments the minor segment and sets the micro segment to zero, then appends .devN

Apparently the “ignoring namespace” makes it work with our <major>.<minor>.x branch names

I checked if the new check works:

grafik

@flying-sheep flying-sheep modified the milestones: 1.11.0, 1.10.4 Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.40%. Comparing base (7ab0bfe) to head (2b740c8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3239      +/-   ##
==========================================
- Coverage   76.73%   76.40%   -0.33%     
==========================================
  Files         109      109              
  Lines       12529    12529              
==========================================
- Hits         9614     9573      -41     
- Misses       2915     2956      +41     

see 1 file with indirect coverage changes

@flying-sheep flying-sheep changed the title Fix release note check Fix release note building and check Sep 17, 2024
@flying-sheep flying-sheep merged commit 8b7673d into main Sep 17, 2024
15 of 22 checks passed
@flying-sheep flying-sheep deleted the fix-release-check branch September 17, 2024 15:02
meeseeksmachine pushed a commit to meeseeksmachine/scanpy that referenced this pull request Sep 17, 2024
flying-sheep added a commit that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant