Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload scrublet scores on test failure #3069

Merged
merged 15 commits into from
Sep 19, 2024
Merged

Upload scrublet scores on test failure #3069

merged 15 commits into from
Sep 19, 2024

Conversation

ilan-gold
Copy link
Contributor

@ilan-gold ilan-gold commented May 17, 2024

  • Release notes not necessary because:

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.73%. Comparing base (78b738b) to head (9c1a28c).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3069   +/-   ##
=======================================
  Coverage   76.73%   76.73%           
=======================================
  Files         109      109           
  Lines       12529    12529           
=======================================
  Hits         9614     9614           
  Misses       2915     2915           

@flying-sheep flying-sheep added this to the 1.10.3 milestone Jun 27, 2024
@flying-sheep
Copy link
Member

hmm, we could just make the upload conditional to the file existing and merge this into main. Then we can debug things as soon as the problem occurs somewhere, and finally undo this PR when commiting the actual fix

@ilan-gold
Copy link
Contributor Author

TODO: creation of zarr store conditional on failed test, and then do the upload conditional on file existence

@flying-sheep flying-sheep changed the title Ig/fix scrublet Add scrublet reproducer Aug 8, 2024
@flying-sheep flying-sheep marked this pull request as ready for review September 17, 2024 12:23
@flying-sheep flying-sheep changed the title Add scrublet reproducer Upload scrublet scores on test failure Sep 17, 2024
@flying-sheep flying-sheep modified the milestones: 1.10.3, 1.10.4 Sep 17, 2024
@flying-sheep flying-sheep merged commit bd75839 into main Sep 19, 2024
19 of 24 checks passed
@flying-sheep flying-sheep deleted the ig/fix_scrublet branch September 19, 2024 08:47
meeseeksmachine pushed a commit to meeseeksmachine/scanpy that referenced this pull request Sep 19, 2024
flying-sheep pushed a commit that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants