Backport PR #2832: Fix for _validate_palette for old numpy versions, …

…prepare 1.9.8 hotfix release (#2833)
scverse · Jan 26, 2024 · 6da39f1 · 6da39f1
1 parent 07c6e90
commit 6da39f1
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/docs/release-notes/1.9.8.md b/docs/release-notes/1.9.8.md
@@ -0,0 +1,5 @@
+### 1.9.8 {small}`2024-01-26`
+
+```{rubric} Bug fixes
+```
+- Fix handling of numpy array palettes for old numpy versions {pr}`2832` {smaller}`P Angerer`
diff --git a/docs/release-notes/release-latest.md b/docs/release-notes/release-latest.md
@@ -1,5 +1,8 @@
 ## Version 1.9
 
+```{include} /release-notes/1.9.8.md
+```
+
 ```{include} /release-notes/1.9.7.md
 ```
 

diff --git a/scanpy/plotting/_utils.py b/scanpy/plotting/_utils.py
@@ -353,8 +353,8 @@ def _validate_palette(adata: anndata.AnnData, key: str) -> None:
                 _palette = None
                 break
         _palette.append(color)
-    # Don't modify if nothing changed
-    if _palette is None or np.equal(_palette, adata.uns[color_key]).all():
+    # Don’t modify if nothing changed
+    if _palette is None or np.array_equal(_palette, adata.uns[color_key]):
         return
     adata.uns[color_key] = _palette