Backport PR #2757: pp.highly_variable_genes handles subset and inplac…

…e consistently (#2774)

Co-authored-by: Eljas Roellin <[email protected]>

docs/release-notes/1.9.7.md

@@ -5,3 +5,4 @@
 - Fix handling of numpy array palettes (e.g. after write-read cycle) {pr}`2734` {smaller}`P Angerer`
 - Specify correct version of `matplotlib` dependency {pr}`2733` {smaller}`P Fisher`
 - Fix {func}`scanpy.pl.violin` usage of `seaborn.catplot` {pr}`2739` {smaller}`E Roellin`
+- Fix {func}`scanpy.pp.highly_variable_genes` to handle the combinations of `inplace` and `subset` consistently {pr}`2757` {smaller}`E Roellin`

scanpy/datasets/_datasets.py

@@ -10,6 +10,7 @@
 from .._settings import settings
 from ..readwrite import read, read_visium
 from ._utils import check_datasetdir_exists, filter_oldformatwarning
+from .._utils import AnyRandom
 
 HERE = Path(__file__).parent
 
@@ -19,6 +20,7 @@ def blobs(
     n_centers: int = 5,
     cluster_std: float = 1.0,
     n_observations: int = 640,
+    random_state: AnyRandom = 0,
 ) -> ad.AnnData:
     """\
     Gaussian Blobs.
@@ -34,6 +36,8 @@ def blobs(
     n_observations
         Number of observations. By default, this is the same observation number
         as in :func:`scanpy.datasets.krumsiek11`.
+    random_state
+        Determines random number generation for dataset creation.
 
     Returns
     -------
@@ -47,7 +51,7 @@ def blobs(
         n_features=n_variables,
         centers=n_centers,
         cluster_std=cluster_std,
-        random_state=0,
+        random_state=random_state,
     )
     return ad.AnnData(X, obs=dict(blobs=y.astype(str)))