-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functions to interactive #315
Add functions to interactive #315
Conversation
In this commit two functions are added to the interactive class. get_layer grabs the layer name and returns the layer if it matches the user input. add_text_to_polygons adds annotations to the chosen polygons/shapes layer
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #315 +/- ##
==========================================
+ Coverage 63.08% 66.44% +3.35%
==========================================
Files 19 19
Lines 2636 2697 +61
==========================================
+ Hits 1663 1792 +129
+ Misses 973 905 -68 ☔ View full report in Codecov by Sentry. |
Hi @minhtien-trinh thanks for your contribution! I reviewed the code and it looks great to me. I ask you please two small adjustments before merging:
Thanks! |
for more information, see https://pre-commit.ci
…nh/napari-spatialdata into feature/interactive
for more information, see https://pre-commit.ci
…nh/napari-spatialdata into feature/interactive
@LucaMarconato I wrote tests, modified the changelog and changed my code so that pre-commit succeeds. For some reason docs fails now and I'm uncertain why. Can you help me? |
It looks like bug in run on CI. git commit -m "trigger ci" --allow-empty |
@LucaMarconato Ready to merge :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two remarks for performance and readability.
improve readability Co-authored-by: Grzegorz Bokota <[email protected]>
for more information, see https://pre-commit.ci
Thanks for the contribution! |
As discussed with @LucaMarconato @melonora and @josenimo, I added two small functions to annotate the shapes/visualize the sample id. The two functions are:
get_layer
grabs the layer name and returns the layer if it matches the user input.add_text_to_polygons
adds annotations/sample names visually to the chosen polygons/shapes layerWhen the user visualizes their data, annotations or simple sample id's could help in identifying samples and aid in analysis.
Example usage would be:
Ideally it will look like this: