-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add scalex #164
add scalex #164
Conversation
Hi, thanks for contributing. The publication was helpful to me for scVI in two regards (more benchmarking of not encoding covariates and conditional batchnorm). However, the conditional VAE design of scVI requires model augmentation and retraining when integrating new data, meaning that scVI is not an online method. This is actually not true and encode_covariates is False by default. (Edited here as the original language was confusing) As a suggestion: Would you be open to contribute SCALEX as either an scvi-tools external package or as a tutorial to scvi-tools. We have an open PR for conditional batchnorm and my first understanding is that when this is merged SCALEX can be used for each scvi-tools model by setting the hyperparameters accordingly. |
Hi @jsxlei, thanks for your contribution! Just a quick edit: looks like the repo doesn't depend on the scverse cookiecutter template, so I'm going to unmark that checkbox. |
Thanks for contributing, @jsxlei! As a quick note — I think there are actually no tests or CI that I can find in the repository at the moment. I'll unmark that checkbox for now as well. |
Thank you for your response. I will
Thank you for your response. I will try to use the exact template. What else to do to be added to the scverse? Thanks! |
Thank you for pointing out! I will add CI soon. |
Hi, Thank you for your suggestions. I am quite open to scVI-tools. How can we make forward on this. (As for the claimed in the paper, it was compared with original scVI in the first paper. We also compared with scVI without the condition in the encoder in our paper.) |
Hi @martinkim0 , I just add the pytest part and follow the cookiecutter template as much as I can including the CI. Danila has helped me checked it. Could you please review and approve the merge when at your convenience. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hey @jsxlei, thanks for the updates! Just to provide more suggestions for improvements:
I don't think any of those are blocking for this PR so I'll merge this one. |
@mikelkou, has this one been announced yet? |
Checklist for adding packages
Mandatory
Name of the tool: SCALEX
Short description: SCALEX is an integration and projection tool for atlas-level single-cell RNA-seq and ATAC-seq data.
How does the package use scverse data structures (please describe in a few sentences):
This package anndata and muon packages as data structure and use scanpy for preprocessing and visualization.
Recommended
@scverse_team
) to include are: