Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scalex #164

Merged
merged 2 commits into from
May 7, 2024
Merged

add scalex #164

merged 2 commits into from
May 7, 2024

Conversation

jsxlei
Copy link
Contributor

@jsxlei jsxlei commented Apr 20, 2024

Checklist for adding packages

Mandatory

Name of the tool: SCALEX

Short description: SCALEX is an integration and projection tool for atlas-level single-cell RNA-seq and ATAC-seq data.

How does the package use scverse data structures (please describe in a few sentences):
This package anndata and muon packages as data structure and use scanpy for preprocessing and visualization.

  • The code is publicly available under an OSI-approved license
  • The package provides versioned releases
  • The package can be installed from a standard registry (e.g. PyPI, conda-forge, bioconda)
  • The package uses automated software tests and runs them via continuous integration (CI)
  • The package provides API documentation via a website or README
  • The package uses scverse datastructures where appropriate (i.e. AnnData, MuData or SpatialData and their modality-specific extensions)
  • I am an author or maintainer of the tool and agree on listing the package on the scverse website

Recommended

  • Please announce this package on scverse communication channels (zulip, discourse, twitter)
  • Please tag the author(s) these announcements. Handles (e.g. @scverse_team) to include are:
    • Twitter: @jsxlei
    • Zulip:
    • Discourse:
    • Mastodon:
  • The package provides tutorials (or "vignettes") that help getting users started quickly
  • The package uses the scverse cookiecutter template.

@canergen
Copy link
Member

canergen commented Apr 20, 2024

Hi, thanks for contributing. The publication was helpful to me for scVI in two regards (more benchmarking of not encoding covariates and conditional batchnorm).
I'm somewhat confused by the statement in the original paper:

However, the conditional VAE design of scVI requires model augmentation and retraining when integrating new data, meaning that scVI is not an online method.

This is actually not true and encode_covariates is False by default.

(Edited here as the original language was confusing) As a suggestion: Would you be open to contribute SCALEX as either an scvi-tools external package or as a tutorial to scvi-tools. We have an open PR for conditional batchnorm and my first understanding is that when this is merged SCALEX can be used for each scvi-tools model by setting the hyperparameters accordingly.

@martinkim0
Copy link

Hi @jsxlei, thanks for your contribution! Just a quick edit: looks like the repo doesn't depend on the scverse cookiecutter template, so I'm going to unmark that checkbox.

@gtca
Copy link

gtca commented Apr 22, 2024

Thanks for contributing, @jsxlei!

As a quick note — I think there are actually no tests or CI that I can find in the repository at the moment. I'll unmark that checkbox for now as well.

@jsxlei
Copy link
Contributor Author

jsxlei commented Apr 22, 2024

Hi @jsxlei, thanks for your contribution! Just a quick edit: looks like the repo doesn't depend on the scverse cookiecutter template, so I'm going to unmark that checkbox.

Thank you for your response. I will

Hi @jsxlei, thanks for your contribution! Just a quick edit: looks like the repo doesn't depend on the scverse cookiecutter template, so I'm going to unmark that checkbox.

Thank you for your response. I will try to use the exact template. What else to do to be added to the scverse? Thanks!

@jsxlei
Copy link
Contributor Author

jsxlei commented Apr 22, 2024

Thanks for contributing, @jsxlei!

As a quick note — I think there are actually no tests or CI that I can find in the repository at the moment. I'll unmark that checkbox for now as well.

Thank you for pointing out! I will add CI soon.

@jsxlei
Copy link
Contributor Author

jsxlei commented Apr 24, 2024

Hi, thanks for contributing. The publication was helpful to me for scVI in two regards (more benchmarking of not encoding covariates and conditional batchnorm). I'm somewhat confused by the statement in the original paper:

However, the conditional VAE design of scVI requires model augmentation and retraining when integrating new data, meaning that scVI is not an online method.

This is actually not true and encode_covariates is False by default.

(Edited here as the original language was confusing) As a suggestion: Would you be open to contribute SCALEX as either an scvi-tools external package or as a tutorial to scvi-tools. We have an open PR for conditional batchnorm and my first understanding is that when this is merged SCALEX can be used for each scvi-tools model by setting the hyperparameters accordingly.

Hi, Thank you for your suggestions. I am quite open to scVI-tools. How can we make forward on this. (As for the claimed in the paper, it was compared with original scVI in the first paper. We also compared with scVI without the condition in the encoder in our paper.)

@jsxlei
Copy link
Contributor Author

jsxlei commented May 2, 2024

Hi @jsxlei, thanks for your contribution! Just a quick edit: looks like the repo doesn't depend on the scverse cookiecutter template, so I'm going to unmark that checkbox.

Hi @martinkim0 , I just add the pytest part and follow the cookiecutter template as much as I can including the CI. Danila has helped me checked it. Could you please review and approve the merge when at your convenience. Thanks!

Copy link

@gtca gtca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gtca
Copy link

gtca commented May 7, 2024

Hey @jsxlei, thanks for the updates!

Just to provide more suggestions for improvements:

I don't think any of those are blocking for this PR so I'll merge this one.

@gtca gtca merged commit 6a4c8bd into scverse:main May 7, 2024
3 checks passed
@grst
Copy link
Contributor

grst commented Jun 4, 2024

@mikelkou, has this one been announced yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants