Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling grpc at the build level #158

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benthecarman
Copy link
Contributor

@benthecarman benthecarman commented Sep 5, 2023

Not going to use this feature and can't get it to compile the proto files. Makes sense to have this as a build flag imo

@scsibug
Copy link
Owner

scsibug commented Sep 5, 2023

Happy to apply, getting a build error right now though:

❯ cargo build
   Compiling nostr-rs-relay v0.8.13 (/Users/scsibug/repos/nostr-rs-relay)
error[E0308]: mismatched types
   --> src/db.rs:146:32
    |
146 |             grpc_client = Some(nauthz::EventAuthzService::connect(&svr).await)
    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `Grpc`, found `EventAuthzService`

error[E0599]: no method named `admit_event` found for mutable reference `&mut config::Grpc` in the current scope
   --> src/db.rs:364:22
    |
363 |                   let decision_res = c
    |  ____________________________________-
364 | |                     .admit_event(
    | |                     -^^^^^^^^^^^ method not found in `&mut Grpc`
    | |_____________________|
    | 

Some errors have detailed explanations: E0308, E0599.
For more information about an error, try `rustc --explain E0308`.
error: could not compile `nostr-rs-relay` (lib) due to 2 previous errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants