-
Notifications
You must be signed in to change notification settings - Fork 126
add: Await InBlock and Broadcast Status When Sending Extrinsic #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@developerfred thanks for your PR. May I ask you to fix the unit test? |
@brenzi I will fix |
It could be that the error actually comes from testing against the wrong node in jenkins. The api-client should now actually test against our node-template #71 |
@developerfred I'v manually tested your PR. It builds, but it doesn't work. Here's how to reproduce:
The log should show you that the client waits for now, change the example:
I would expect it to wait for |
db235b9
to
9344146
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please stop working on this
9344146
to
137b432
Compare
4696647
to
6dec485
Compare
I'm sorry that I have to disappoint you @developerfred but we do prefer to wait for a task until it is well done and reviewing it when it is tested and ready |
#65
update jenkins
#74