Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for hash matching for unchecked extrinsic #636

Merged
merged 5 commits into from
Aug 2, 2023
Merged

Add unit tests for hash matching for unchecked extrinsic #636

merged 5 commits into from
Aug 2, 2023

Conversation

haerdib
Copy link
Contributor

@haerdib haerdib commented Jul 28, 2023 •
edited
Loading

Adds unit tests to ensure the calculated extrinsic hash matches the one from Substrate.

related to #624

@haerdib haerdib self-assigned this Jul 28, 2023
@haerdib haerdib changed the title Add unit test for hash matching for unchecked extrinsic Add unit tests for hash matching for unchecked extrinsic Jul 28, 2023
@haerdib haerdib marked this pull request as ready for review July 28, 2023 12:26
@haerdib haerdib mentioned this pull request Jul 28, 2023
Closed
Niederb
Niederb approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@Niederb Niederb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for the tests and the improved documentation.

echevrier
echevrier approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@echevrier echevrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@haerdib haerdib merged commit 7e0646f into master Aug 2, 2023
38 checks passed
@haerdib haerdib deleted the bh/update-unchecked-extrinsic branch August 2, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echevrier echevrier echevrier approved these changes

@Niederb Niederb Niederb approved these changes

Assignees

@haerdib haerdib

Labels
E1-breaksnothing F3-test fix tests or CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haerdib @Niederb @echevrier