Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signAmino(): use memo from signed transaction instead of from the caller #163

Merged
merged 6 commits into from
Mar 18, 2024

Conversation

assafmo
Copy link
Member

@assafmo assafmo commented Mar 18, 2024

Fixes #161

Before now, signAmino() used memo from the caller. This made it so if the signer changed the memo before signing, the transaction would fail because of a signature mismatch.

Note: this bug only existed in signAmino() and not in signDirect().

assafmo added 5 commits March 18, 2024 13:07
Before that we used the memo that the caller to signAmino() gave us. This made it so if the signer changed the memo before signing, the tx would fail because of a signature mismatch.
@assafmo assafmo changed the title signAmino(): use memo from signed transaction instead from the caller signAmino(): use memo from signed transaction instead of from the caller Mar 18, 2024
Copy link

cloudflare-workers-and-pages bot commented Mar 18, 2024

Deploying secretjs-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 505ef9a
Status: ✅  Deploy successful!
Preview URL: https://70d07fc5.secretjs-scrt-network.pages.dev
Branch Preview URL: https://fix-signamino-memo.secretjs-scrt-network.pages.dev

View logs

@assafmo assafmo merged commit 2defd1b into master Mar 18, 2024
3 checks passed
@assafmo assafmo deleted the fix-signAmino-memo branch March 18, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transaction failed when write memo on keplr
1 participant