feat: engine driver #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greged93
commented
Jan 17, 2025
|
|
||
| /// The payload attributes for block building tailored for Scroll. | ||
| #[derive(Debug, Clone, Default, Serialize, Deserialize)] | ||
| pub struct ScrollPayloadAttributes { |
There was a problem hiding this comment.
I will move this to scroll-alloy-rpc-types-engine once the alloy PR is merge on Reth.
greged93
commented
Jan 17, 2025
crates/engine/src/payload.rs
Outdated
| /// - all transactions match | ||
| /// - timestamps are equal | ||
| /// - `prev_randaos` are equal | ||
| /// - TODO: should we also compare the `fee_recipient` with the `suggested_fee_recipient`? |
There was a problem hiding this comment.
Is this header.coinbase? It is currently used by Clique.
Thegaram
approved these changes
Jan 17, 2025
frisitano
reviewed
Jan 20, 2025
georgehao
reviewed
Jan 21, 2025
crates/engine/src/engine.rs
Outdated
| safe_head: BlockInfo, | ||
| finalized_head: BlockInfo, | ||
| ) -> Self { | ||
| let fcu = ForkchoiceState { |
There was a problem hiding this comment.
Suggested change
| let fcu = ForkchoiceState { | |
| let fcs = ForkchoiceState { |
georgehao
reviewed
Jan 21, 2025
crates/engine/src/engine.rs
Outdated
Comment on lines
57
to
68
| loop { | ||
| match client.fork_choice_updated_v1(fcu, None).await { | ||
| Err(err) => { | ||
| debug!(target: "engine::driver", ?err, "waiting on engine client"); | ||
| tokio::time::sleep(tokio::time::Duration::from_secs(1)).await; | ||
| } | ||
| Ok(status) => { | ||
| info!(target: "engine::driver", payload_status = ?status.payload_status.status, "engine ready"); | ||
| break | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| loop { | |
| match client.fork_choice_updated_v1(fcu, None).await { | |
| Err(err) => { | |
| debug!(target: "engine::driver", ?err, "waiting on engine client"); | |
| tokio::time::sleep(tokio::time::Duration::from_secs(1)).await; | |
| } | |
| Ok(status) => { | |
| info!(target: "engine::driver", payload_status = ?status.payload_status.status, "engine ready"); | |
| break | |
| } | |
| } | |
| } | |
| // wait on engine | |
| while let Err(err) = client.fork_choice_updated_v1(fcu, None).await { | |
| debug!(target: "engine::driver", ?err, "waiting on engine client"); | |
| tokio::time::sleep(tokio::time::Duration::from_secs(1)).await; | |
| } | |
| info!(target: "engine::driver", "engine ready"); |
There was a problem hiding this comment.
We need to keep Ok(status) to log it
georgehao
reviewed
Jan 21, 2025
| /// The finalized L2 block info. | ||
| finalized_block_info: BlockInfo, | ||
| /// Marker | ||
| _types: std::marker::PhantomData<ET>, |
There was a problem hiding this comment.
just curious about why this variable need a _
There was a problem hiding this comment.
PhantomData is a zero-sized type that is only there to give a hint about ET to the compiler. So this field will never be accessed. The _ prefix just tells the compiler that this field is not used and prevents warnings (see here).
frisitano
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the engine driver component to the rollup node. The Engine driver is the interface to the Engine API of the EN and handles communicating new safe and unsafe payloads to the EN.
Resolves #5