Feat/skip fixed commit of range table #797
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hero78119
reviewed
Dec 31, 2024
ceno_zkvm/src/circuit_builder.rs
Outdated
| @@ -94,6 +94,10 @@ pub struct ConstraintSystem<E: ExtensionField> { | |||
| pub num_fixed: usize, | |||
| pub fixed_namespace_map: Vec<String>, | |||
|
|
|||
| pub num_structural_fixed: usize, | |||
| pub structural_fixed_namespace_map: Vec<String>, | |||
| pub structural_fixed_len: Vec<usize>, | |||
There was a problem hiding this comment.
I think we dont need to define new structural_fixed. Instead we can just reuse current structural_witin?
naure
reviewed
Jan 2, 2025
hero78119
approved these changes
Jan 9, 2025
| @@ -75,12 +66,19 @@ impl RangeTableConfig { | |||
| mlts[*idx as usize] = *mlt; | |||
| } | |||
|
|
|||
| let offset_range = StructuralWitIn { | |||
There was a problem hiding this comment.
Just indicate some following up improvement: previous it's fixed column, thus fixed column just generate once and cached. Now we save prover key size & no PCS opening anymore on range column, but we need to assign and create same witness polynomial every time. We can improve this by introducing a extra design cache structural witness column for first time and reuse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work for #789