Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage and typings updates #28

Merged
merged 15 commits into from
Oct 31, 2023
Merged

Usage and typings updates #28

merged 15 commits into from
Oct 31, 2023

Conversation

scriptex
Copy link
Owner

This PR:

  1. updates the usage by simplifying it.
  2. improves the typings by adding return types for all methods and fixing the wrong type of the optional callback in all methods.

@scriptex scriptex added the enhancement New feature or request label Oct 30, 2023
@scriptex scriptex self-assigned this Oct 30, 2023
@scriptex scriptex marked this pull request as draft October 30, 2023 07:07
@scriptex scriptex linked an issue Oct 30, 2023 that may be closed by this pull request
Improvements #25
Closed
@scriptex scriptex marked this pull request as ready for review October 31, 2023 06:54
@sonarcloud
Copy link

sonarcloud bot commented Oct 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@scriptex scriptex merged commit 06fcd0d into main Oct 31, 2023
8 checks passed
@scriptex scriptex deleted the updates branch October 31, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@scriptex scriptex

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improvements
1 participant
@scriptex