Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for KeyboardStyling #502

Merged

Conversation

vickcoo
Copy link
Contributor

@vickcoo vickcoo commented Sep 5, 2024

Contributor checklist


Description

Add a unit tests for KeyboardStyling.swift.

Related issue

Copy link

github-actions bot commented Sep 5, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-iOS repo
  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CI unit test workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@vickcoo
Copy link
Contributor Author

vickcoo commented Sep 5, 2024

Hi @andrewtavis, I need your review 🤳🏻

@andrewtavis
Copy link
Member

Do you want to do a first review of this, @fabulouiOS-monk? :) Happy to check it before or after 😊

@fabulouiOS-monk
Copy link
Collaborator

I think I have reviewed from my side, there are some typos in method name. But I am finished with my review. Thanks @andrewtavis.

@andrewtavis
Copy link
Member

I'll check and fix the names in my review then, @fabulouiOS-monk :) Thanks so much!

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all of these, @vickcoo! Really great to be making so much progress with testing already! Let us know in the issue what you'd think would be the next best thing to work on 😊

@andrewtavis andrewtavis merged commit 2521978 into scribe-org:main Sep 6, 2024
2 checks passed
@vickcoo vickcoo deleted the add-unit-tests-keyboard-styling branch September 8, 2024 15:22
@vickcoo
Copy link
Contributor Author

vickcoo commented Sep 8, 2024

Hi @andrewtavis, I'll be work on the KeyboardKeys as the next tests!

@andrewtavis
Copy link
Member

Nice, @vickcoo! Looking for are to the tests! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants