-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for KeyboardStyling #502
Add unit tests for KeyboardStyling #502
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
Hi @andrewtavis, I need your review 🤳🏻 |
Do you want to do a first review of this, @fabulouiOS-monk? :) Happy to check it before or after 😊 |
I think I have reviewed from my side, there are some typos in method name. But I am finished with my review. Thanks @andrewtavis. |
I'll check and fix the names in my review then, @fabulouiOS-monk :) Thanks so much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all of these, @vickcoo! Really great to be making so much progress with testing already! Let us know in the issue what you'd think would be the next best thing to work on 😊
Hi @andrewtavis, I'll be work on the KeyboardKeys as the next tests! |
Nice, @vickcoo! Looking for are to the tests! :) |
Contributor checklist
Description
Add a unit tests for KeyboardStyling.swift.
Related issue