Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to toggle double space period shortcuts. #491

Merged

Conversation

vickcoo
Copy link
Contributor

@vickcoo vickcoo commented Aug 20, 2024

Contributor checklist


Description

Add an option in the Functionality section for each language keyboard, that allow user to turn off double space period shortcuts , turn on by default.

Reference Figma design here.

Related issue

Copy link

github-actions bot commented Aug 20, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-iOS repo
  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review August 20, 2024 16:41
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really is a wonderful first contribution, @vickcoo! I'll send along a quick changelog update momentarily. As far as the Swiftlint errors, I'd suggest checking out the pre-commit suggestions in the development environment section of the contributing guide. That'll check your code for these errors and prevent you from committing if they're in there 😇

Would be wonderful to work with you again! Super great to have you in the community 😊

@andrewtavis andrewtavis merged commit 56a06d5 into scribe-org:main Aug 20, 2024
1 check passed
@vickcoo
Copy link
Contributor Author

vickcoo commented Aug 20, 2024

Oops! Missed that part. I’ll check the pre-commit.

@vickcoo vickcoo deleted the 479-double-space-period-shortcut-option branch August 20, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants