Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(swiftlint): remove blanket_disable_command from disabled rules #489

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

jon-tous
Copy link
Contributor

There are no violations currently in the project. We can enable this rule moving forward to prevent future violations.

Contributor checklist


Description

I removed blanket_disable_command from disabled_rules in .swiftlint.yml and no violations were flagged.

Running swiftlint --strict confirmed: Done linting! Found 0 violations, 0 serious in 86 files. This rule can now be enforced by SwiftLint moving forward to prevent new violations from entering the codebase.

The only change was removing this line from from .swiftlint.yml so no functionality is affected. App builds and runs as normal on iPhone 15 Pro simulator (iOS 17.5).

Related issue

There are no violations currently in the project. We can enable this rule moving forward to prevent future violations.
Copy link

github-actions bot commented Aug 13, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-iOS repo
  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review August 13, 2024 23:30
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jon-tous! Maybe the earlier issues were fixed as we worked on other issues 😊

@andrewtavis andrewtavis merged commit 300e5b6 into scribe-org:main Aug 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants