Enter selected text into Scribe

[Jag-Marcel]

Contributor checklist

• This pull request is on a separate branch and not the main branch

---

Description

These are changes to the behaviour of the Scribe key when text in the text field is selected. Currently, it only shows you annotations for the selected word (i.e. "N" for neuter words). Here, I changed it so the selected Scribe command's action is executed on the highlighted text.

Before

After (after pressing "Plural" in the command bar)

We also considered an option where the text would simply be entered into the command bar's text field, but decided against it:

Related issues

• Rework Scribe key press when selecting a word #141

[github-actions]

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

• The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

  • The contributor's name and icon in remote commits should be the same as what appears in the PR
  • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-iOS repo

• The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

• The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

[andrewtavis]

A few things to consider here, @Jag-Marcel:

• What happens if the word isn't the last one in the proxy?
  • Do we replace the word where the other one is
• We also need to make sure that we're not including a space at the end of such commands that might cause an inadvertent double space for the user
  • Maybe we can check to see if there is a space after the word already so that we only add a space if there isn't one already 🤔

This is amazing! Thank you! 🚀

[andrewtavis]

Talking about it in the sync: The general thinking is that the command should be directly ran :)

[andrewtavis]

This is ready for a file review at this point, right @Jag-Marcel? :)

[Jag-Marcel]

This is ready for a file review at this point, right @Jag-Marcel? :)

Not yet, I still haven't changed the behaviour with the commands

[Jag-Marcel]

Ready to review now, @andrewtavis! I also edited the description of the PR to match.

[andrewtavis]

Fantastic, @Jag-Marcel! Will get to this soon :) Working on getting emojis for the English keyboard via implementing it in Scribe-Data, and then the translations :)

[andrewtavis]

Really amazing work here, @Jag-Marcel! 😊 Thanks so much for putting so much care into this issue! Really has turned out wonderfully, and using it even in testing was really fun :D