Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reset icon to reset app hints option in the app about tab 475 #478

Conversation

fabulouiOS-monk
Copy link
Collaborator

Contributor checklist


Description

  1. I added an icon for the reset app hints menu option on the About screen.
  2. I added a row for a link to Mastodon and Mastodon icons for light and dark mode.
  3. Updated the icon for app hints in the About screen, it was previously lightbulb instead it should have been lightbulb.max

Related issue

Copy link

github-actions bot commented Jul 27, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-iOS repo
  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@fabulouiOS-monk
Copy link
Collaborator Author

@andrewtavis, PR holds fixes for :

  1. Add link to Mastodon to the app About tab #474
  2. Add reset icon to reset app hints option in the app About tab #475

@andrewtavis andrewtavis self-requested a review July 27, 2024 16:06
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @fabulouiOS-monk! Thanks so much for getting to this so quickly!

@andrewtavis andrewtavis merged commit 2ea3f5d into scribe-org:main Jul 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants