Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created .pre-commit-config.yaml and installed hooks #460

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

henrikth93
Copy link
Member

Created pre-commit-config.yaml and installed hooks.

Contributor checklist


Description

Related issue

Created pre-commit-config.yaml and installed hooks.
Copy link

github-actions bot commented Jun 12, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-iOS repo
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@@ -0,0 +1,6 @@
repos:
- repo: https://github.com/realm/SwiftLint
rev: 0.50.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick note here @henrikth93: pre-commit revs are directly from the projects that they're leveraging, so it's good to always check what the latest version is! I figured this out recently when setting pre-commit up for multiple repos 😇 For this one it's actually at 0.55.1. Have it updated locally and will send it along shortly!

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @henrikth93! Really happy to have this running on Scribe-iOS now. Let's definitely show this off at the sync on Saturday!

@andrewtavis andrewtavis merged commit 34d41bf into scribe-org:main Jun 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants