Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed swiftLint warning closure_parameter_position #434

Conversation

fabulouiOS-monk
Copy link
Collaborator

Contributor checklist


Description

Related issue

Copy link

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-iOS repo
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review May 17, 2024 22:09
@andrewtavis
Copy link
Member

Hey @fabulouiOS-monk 👋 Quick note that it looks like there's something wrong with how your email's set up for your account. You'll notice in the commits that the name and image are different from your account that the PR is from. As detailed in the maintainer checklist, could you make sure that the email you use for GitHub matches what you have for git config user.email in your local Scribe-iOS repo :) We can see if that fixes the PRs you've opened, or if not you can re-open. From experience though, if you don't change it then you won't be marked as a Scribe contributor once this is merged :)

@andrewtavis
Copy link
Member

Same thing for #436 :)

@fabulouiOS-monk
Copy link
Collaborator Author

Hi @andrewtavis, Thank you for informing me. I see my email is mismatched. I will be Re-opening PR for both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants