Refactoring for improved code readability

[LeTarrask]

Contributor checklist

• This pull request is on a separate branch and not the main branch

---

Description

Basically, replaced the if !=nil to !isEmpty, and added a couple of guard let to make it easier to understand a few long ifs.

As a suggestion to make it more readable, we can add this extension to array:

extension Array { var isNotEmpty: Bool { isEmpty == false } }

If agreed, I could add the Array extension file and replace the odd !isEmpty for a .isNotEmpty check.

Related issue

• [Refactor] Improve code quality #379

[github-actions]

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. It'd be great to have you!

Maintainer checklist

• The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

  • The contributor's name and icon in remote commits should be the same as what appears in the PR
  • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-iOS repo

• The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

[andrewtavis]

I'm sorry for your experience here, @LeTarrask :( Am really slammed at the moment and haven't been able to prioritize this. I did plan to bring this in eventually... I'll reference your code and make the changes myself. Really appreciate your time here, and again my apologies.

[LeTarrask]

No problem, man. I totally understand. I was super slow the week I worked on the code, then got slammed, too, and almost forgot about the pull request. Let me know if there’s more I can do to help. Slow times are here again. :) Alex Luna Digital Creative & iOS Developer | tarrask.com +351 925 885 755 <tel:+351 925 885 755> ***@***.*** ***@***.***> www.tarrask.com <//www.tarrask.com> Lisbon, Portugal

…

On Mar 5, 2024, at 15:46, Andrew Tavis McAllister ***@***.***> wrote: I'm sorry for your experience here, @LeTarrask <https://github.com/LeTarrask> :( Am really slammed at the moment and haven't been able to prioritize this. I did plan to bring this in eventually... I'll reference your code and make the changes myself. Really appreciate your time here, and again my apologies. — Reply to this email directly, view it on GitHub <#385 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADRTESQLW6LCXSAW4BCWRLDYWXSE3AVCNFSM6AAAAAA7THWCXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZZGA3TGNZWGU>. You are receiving this because you were mentioned.