Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Extract DB access logic from functionalities and views #381

Merged
merged 4 commits into from
Apr 2, 2024
Merged

Refactor: Extract DB access logic from functionalities and views #381

merged 4 commits into from
Apr 2, 2024

Conversation

flumaves
Copy link
Contributor

@flumaves flumaves commented Nov 4, 2023

Contributor checklist


Description

  • Rename loadData.swift to LanguageDBManager.swift
  • About LanguageDBManager, the DB is accessed from multiple places externally, so designing it as a singleton is a suitable method.

Notes about LanguageDBManager

  • Direct operations on the database are not allowed and can only be completed by the manager.
  • Extract database access in views and functions into separate methods as an extension to LanguageDBManager.
  • SQL query statements should be written in the extension method. Adding new methods should also be written in the extension and avoid duplicate methods.

Copy link

github-actions bot commented Nov 4, 2023

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-iOS repo
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review November 4, 2023 13:23
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies that this review took so long and that the merge is as messy as it's going to have to be, @flumaves. There's been lots going on that I've needed to direct my attention to. It was not my intention to have this take as long as did.

There are some issues with some features breaking with the new changes. Didn't have the capacity to deal with them till now, but now the merge conflicts have grown. I'll bring in the new db file and then will go through the commits here to rework the conversion of the SQLite calls resembling your approaches.

Appreciate the contribution! Hope that all's well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants