-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CONTRIBUTING.md #370
Conversation
Changing documentation to make easy for ease of access to contributors
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. It'd be great to have you! Maintainer checklist
|
CONTRIBUTING.md
Outdated
# Navigate to the newly cloned directory | ||
cd <repo-name> | ||
cd Scribe-iOS.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this we don't need the .git :)
CONTRIBUTING.md
Outdated
|
||
2. If you cloned a while ago, get the latest changes from upstream: | ||
|
||
```bash | ||
git checkout <dev-branch> | ||
git pull upstream <dev-branch> | ||
git checkout main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These here we can leave as <dev-branch>
as was done in the [PR we're referencing] :)
We should be good once the changes I mentioned above are fixed, @kuddlefishbwaa. There's gonna be one more minor change in the activist repo, so I'm going to wait till that's finished as maybe we'll want to do that over here as well! Appreciate the help here! |
Fixed contribution, returning <dev-branch> and removing the .git from other areas.
Removing one more .git
Removed the things requested, I'll wait for more information on what else needs to be done! :) |
I can start updating with the info from the other pull request as well if you would like. :) |
Sure thing, @kuddlefishbwaa! Thanks for keeping on top of all this! 😊 |
Hey there @kuddlefishbwaa 👋 We're done updating the contributing and readme at activist, so we're good to go as far as making the documentation over here equivalent 😊 Thanks for your patience! |
Great I will start looking through that to start making changes |
Thanks, @kuddlefishbwaa! Looking forward to the further changes :) |
Another thing that would be great to add in here @kuddlefishbwaa would be to add a reference to commitlint to the contributing guidelines in section 4 of the pull requests section. |
I just made a commit to activist that adds the following: > [!NOTE]\
> The following are tools and methods to help you write good commit messages ✨
>
> - [commitlint](https://commitlint.io/) helps write [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/)
> - Git's [interactive rebase](https://docs.github.com/en/github/getting-started-with-github/about-git-rebase) cleans up commits |
Quick note on this, @kuddlefishbwaa: we can also use add in a quick bit about how the user can use Xcode to clone a repository in the case of iOS. Happy to add it myself, but wanted to send it along so we remember :) |
Hey @kuddlefishbwaa 👋 Are you planning any other commits here, or should I review? :) |
I'm going to check over some more with some teammates about Xcode and see if they have thoughts on making it easier to walk through! 😄 |
Sounds good, @kuddlefishbwaa :) Thank you! |
Updated first steps with correct links for Scribe
The team thinks that the Xcode steps are forward enough as is. But I did change some links from the copy over of the starting steps in Contributing. If you have comments or examples of how you would like the Xcode to be outlined if you feel that to be necessary. But otherwise we are good to go! |
Thank you, @kuddlefishbwaa! I'll review this in the coming days :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry that this review took so long, @kuddlefishbwaa :) Has been a very busy month and a bit for me. Appreciate the work here! I'll go through and make any needed changes and close out the issue 🚀
Contributor checklist
Description
Changing documentation to make easy for ease of access to contributors
Related issue