Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set light text in light mode in Settings and About screens #356

Merged
merged 1 commit into from
Aug 20, 2023

Conversation

aymericd12
Copy link
Contributor

@aymericd12 aymericd12 commented Aug 19, 2023

Contributor checklist


Description

This PR sets light text in light mode in the Settings and About screens. Changes are:

  • Info.plist:
    • Set UIStatusBarStyle to UIStatusBarStyleLightContent. This sets the light text in the status bar for the entire app.
    • Set UIViewControllerBasedStatusBarAppearance to NO. This prevents the status bar appearance to change within a screen.
  • InstallationVC.swift: remove the override of the var preferredStatusBarStyle

Related issue

@github-actions
Copy link

github-actions bot commented Aug 19, 2023

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The CHANGELOG has been updated with a description of the changes for the upcoming release (if necessary)

@andrewtavis andrewtavis self-requested a review August 19, 2023 08:11
@andrewtavis
Copy link
Member

Thanks for the PR, @aymericd12! I'll try to get to this review later on today or tomorrow :) :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked it and all's working great, @aymericd12! Really appreciate you coming in and fixing this for us! Would be great to have you in the iOS channel of our Matrix space if you'd like to work on more issues!

All the best 😊

@andrewtavis andrewtavis merged commit 294337b into scribe-org:main Aug 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants