Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swiping between tabs using SwipeableTabBarController #349

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

SaurabhJamadagni
Copy link
Collaborator

Contributor checklist


Description

This PR adds the ability to swipe between menu tabs. It uses the SwipeableTabBarController package.

@andrewtavis could you test it out on a physical device if possible? Seems to work great on the simulator. I would have but then for me to run it on my device it will have to go and provision certificates for all languages and that's causing some problem.

Related issue

@github-actions
Copy link

github-actions bot commented Aug 10, 2023

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The CHANGELOG has been updated with a description of the changes for the upcoming release (if necessary)

@andrewtavis andrewtavis self-requested a review August 10, 2023 22:49
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, @SaurabhJamadagni :) I don't have testing setup on a physical device, but let's just role with this and we can react to it if it's not working locally. If this is concerning for you (which I totally agree it's not best practice), then I can set something up before release. No stress 😊

Thanks for this!

@andrewtavis andrewtavis merged commit b9f70d7 into scribe-org:main Aug 11, 2023
1 check passed
@andrewtavis andrewtavis added the GSoC Available for Google Summer of Code participants label Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC Available for Google Summer of Code participants
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants