-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: saving user preference on emoji autosuggest based on menu #347
feat: saving user preference on emoji autosuggest based on menu #347
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! It'd be great to have you! Maintainer checklist
|
@SaurabhJamadagni, just checking with you on whether it's set up to have the default be that this option is enabled :) Doesn't seem to be working as of now. I think we're good to go when that's set up! |
Sorry about the delay @andrewtavis. Making the changes now. |
Hey @andrewtavis, I am pushing the changes to assign defaults. Sharing a code snippet using which you could reset the UserDefaults. I ran it in my let domain = "group.scribe.userDefaultsContainer"
UserDefaults.standard.removePersistentDomain(forName: domain)
print("user defaults have been reset") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, @SaurabhJamadagni! Thanks for getting to these changes :) :) Hope you've had a nice weekend!
Contributor checklist
Description
Following up on issue #310, this PR adds the functionality for emoji autosuggest menu item. Changes include:
Related issue
Hey @andrewtavis, I tested this with most of the cases where emojis would be suggested. Seems to work so far. Let me know if you come across a case where the emojis are showing despite the menu item. Probably missing a condition in that case but currently I think all cases should be covered.