Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design fixes discussed in scribe weekly 3/7/23 #338

Merged
merged 3 commits into from
Jul 5, 2023

Conversation

SaurabhJamadagni
Copy link
Collaborator

Contributor checklist


Description

Hey @andrewtavis!

Here's the PR for the design fixes that were discussed in our last meeting. I hope I have covered everything. Do let me know if I missed anything. The changes include:

  • Increasing separation between sections as well as the first section and title.
  • Changing tab bar icon colour to be linkBlue so that it is inverse of the current theme (dark or light mode).
  • Increased the size of the settings icon a little.

Related issue

N/A

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The CHANGELOG has been updated with a description of the changes for the upcoming release (if necessary)

@andrewtavis andrewtavis self-requested a review July 5, 2023 22:25
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks great, @SaurabhJamadagni! Thanks for the quick changes here 😊🚀

@andrewtavis andrewtavis merged commit a3faa52 into scribe-org:main Jul 5, 2023
@SaurabhJamadagni SaurabhJamadagni deleted the design-fixes branch July 6, 2023 05:06
@andrewtavis andrewtavis added the GSoC Available for Google Summer of Code participants label Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC Available for Google Summer of Code participants
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants