Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding reference to blog post 1 in README #333

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

SaurabhJamadagni
Copy link
Collaborator

Contributor checklist


Description

PR adds reference to blog post regarding GSoC documentation in Featured By section of the README.

Related issue

  • N/A

@github-actions
Copy link

github-actions bot commented Jun 21, 2023

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The CHANGELOG has been updated with a description of the changes for the upcoming release (if necessary)

README.md Outdated
@@ -236,6 +236,7 @@ A future feature of Scribe is language practice within the app itself. Scribe pr
<strong>2023</strong>

- [Presentation slides](https://docs.google.com/presentation/d/1W4ZkGi9UDDiTxM_silEij0gTE8YEubluHxe78xoqEP0/edit?usp=sharing) for a talk at [Berlin Hack and Tell](https://berlinhackandtell.rocks/) ([Hack of the month winner 🏆](https://berlinhackandtell.rocks/2023-03-28-no87-moore-hacks))
- [Blog post 1](https://saurabhjamadagni.hashnode.dev/nested-uitableviews-apples-built-in-viewcontrollers) for documenting GSoC '23 with Scribe
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🙌

IIRC what you shared before, there'll be more posts, right?

Quick nit - but one way that the posts could be added too:

Suggested change
- [Blog post 1](https://saurabhjamadagni.hashnode.dev/nested-uitableviews-apples-built-in-viewcontrollers) for documenting GSoC '23 with Scribe
- [Blog post](https://saurabhjamadagni.hashnode.dev/nested-uitableviews-apples-built-in-viewcontrollers) on {THE WORK I DID THAT THE POST GOES OVER} for [GSoC '23]({URL TO MAYBE PHABRICATOR/GSOC WHERE THE SCRIBE GSOC INITIATIVE IS DOCUMENTED})

More so thinking that this might provide a more specific synopsis to help folks who come across the Featured by

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya I think that that would be more appealing for people to click on :) Also, the featured by section starts with the newest elements, so this should go above the Berlin Hack and Tell slides 🙃

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I didn't know that for sure, but intuitively that makes sense 👍

I don't think the specific day would be necessary, but could it make sense to prefix each listing with the month at least?


If so, doesn't have to happen in this PR; can happen later. Just something I thought of.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya I can do a commit with those later 🙃 Adding it to my tasks for this week :)

Copy link
Collaborator Author

@SaurabhJamadagni SaurabhJamadagni Jun 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that makes a lot of sense. I was skeptical about the content to add. Let me make the above changes. Here's a link to Mediawiki accepted projects page where Scribe is mentioned. Does this sound like a good link to redirect to or is there anything else I should link to?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That link makes sense to me, @SaurabhJamadagni! :) :) Thank you! 🙌

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed the changes right now. Thanks for the suggestion @wkyoshida 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final question on this: looking again, should the link be titled Scrbe development blog post instead of just Blog post? Just jumped out at me as maybe being a bit better :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about 'Scribe iOS development blog post on Nested UITableViews & Apple's built-in ViewControllers in app menu for GSoC '23'?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that'd be solid 😊

@andrewtavis andrewtavis self-requested a review June 23, 2023 16:11
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this so I can do the rest of the changes and add in the months as we discussed 😊

@andrewtavis
Copy link
Member

Will change the name as I do that 🙃

@andrewtavis andrewtavis merged commit f363ad5 into scribe-org:main Jun 23, 2023
@SaurabhJamadagni
Copy link
Collaborator Author

I'll merge this so I can do the rest of the changes and add in the months as we discussed 😊

Cool thank you @andrewtavis! 😊

@andrewtavis andrewtavis added the GSoC Available for Google Summer of Code participants label Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC Available for Google Summer of Code participants
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants