Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qid & testing add #199

Merged
merged 1 commit into from
Sep 20, 2024
Merged

qid & testing add #199

merged 1 commit into from
Sep 20, 2024

Conversation

axif0
Copy link
Contributor

@axif0 axif0 commented Sep 19, 2024

Contributor checklist


Description

moved data_type_metadata part and then load that in and use it instead of data_type_to_qid. Also, add tests for get_qid_by_input.

image
image

Related issue

Copy link

github-actions bot commented Sep 19, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo
  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review September 19, 2024 17:53
@andrewtavis
Copy link
Member

Thanks for the PR, @axif0! I'll try to bring it in later :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All really great, @axif0! Appreciate the continued contributions to Scribe-Data! 🚀😊

@andrewtavis andrewtavis merged commit a4a33de into scribe-org:main Sep 20, 2024
4 checks passed
@andrewtavis andrewtavis mentioned this pull request Sep 20, 2024
2 tasks
@axif0 axif0 deleted the qid-json branch October 3, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants