-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor redundant code fix #195
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
@@ -324,7 +324,6 @@ def table_insert(data_type, keys): | |||
) | |||
|
|||
print("Database creation/update process completed.") | |||
print("Database creation/update process completed.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
Can you check out the tests here, @axif0 :) I'm not sure that we can import variables from another files that are defined with |
@andrewtavis My bad I forgot to check the tests. Can you please check it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All seems to be working well now, @axif0! Appreciate all the cleanup you're doing! 🚚😊
Contributor checklist
Description
We can reuse cli_utils code in list.py