Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor redundant code fix #195

Merged
merged 3 commits into from
Sep 2, 2024
Merged

minor redundant code fix #195

merged 3 commits into from
Sep 2, 2024

Conversation

axif0
Copy link
Contributor

@axif0 axif0 commented Sep 2, 2024

Contributor checklist


Description

We can reuse cli_utils code in list.py

Copy link

github-actions bot commented Sep 2, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo
  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@@ -324,7 +324,6 @@ def table_insert(data_type, keys):
)

print("Database creation/update process completed.")
print("Database creation/update process completed.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@andrewtavis
Copy link
Member

Can you check out the tests here, @axif0 :) I'm not sure that we can import variables from another files that are defined with with ... as .... Maybe you could remove those and just have this be to remove the repeat print statement? Happy to hear your thoughts though!

@axif0
Copy link
Contributor Author

axif0 commented Sep 2, 2024

@andrewtavis My bad I forgot to check the tests. Can you please check it?

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems to be working well now, @axif0! Appreciate all the cleanup you're doing! 🚚😊

@andrewtavis andrewtavis merged commit af63f1e into scribe-org:main Sep 2, 2024
3 checks passed
@axif0 axif0 deleted the code_cleanv1 branch October 3, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants