Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Unittest for CLI #192

Merged
merged 3 commits into from
Aug 30, 2024
Merged

More Unittest for CLI #192

merged 3 commits into from
Aug 30, 2024

Conversation

mhmohona
Copy link
Member

Contributor checklist


Description

Added some more test cases.

image

Changed cli_util.py a bit to integrate tests for it.

Related issue

  • #ISSUE_NUMBER

Copy link

github-actions bot commented Aug 28, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo
  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review August 28, 2024 20:18
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My changes were just formatting here as we had single quote strings in many places and imports weren't sorted. Thanks for this, @mhmohona! Great to have such an expansive testing suite 😊

@andrewtavis andrewtavis merged commit 2c50a66 into scribe-org:main Aug 30, 2024
3 checks passed
@mhmohona mhmohona deleted the unittest branch August 31, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants