Add test for CLI tool

[mhmohona]

Contributor checklist

• This pull request is on a separate branch and not the main branch

---

Description

Related issue

• #ISSUE_NUMBER

[github-actions]

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

• The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

  • The contributor's name and icon in remote commits should be the same as what appears in the PR
  • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo

• The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

• The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

[wkyoshida]

Hey, @mhmohona! 👋

I noticed the tests appear to be failing when running in the CI. Did notice also though that the screenshot in the PR description shows the tests do run OK when pytest is ran within src/scribe_data/cli. Does running pytest in the root of the project still run OK too?

[mhmohona]

Hey, @mhmohona! 👋

I noticed the tests appear to be failing when running in the CI. Did notice also though that the screenshot in the PR description shows the tests do run OK when pytest is ran within src/scribe_data/cli. Does running pytest in the root of the project still run OK too?

Thank you @wkyoshida for looking into this. The thing is this tests passes when everything is in one place. I mean all the files, total.py, list.py, query.py is in one branch, then these tests works without any error. Both unittest and Pytest passes. I tried it locally and it passes as you can see in screenshot.

[andrewtavis]

Ok so the tests are passing, but then a question I have is when are the tests that we have written here ran? Is it possible to move the tests for the CLI into the Scribe-Data/tests directory such that they're ran as a part of the pytest suite?

[andrewtavis]

Would you be able to make this change, @mhmohona? Let us know if you have any questions!

[mhmohona]

Ok so the tests are passing, but then a question I have is when are the tests that we have written here ran? Is it possible to move the tests for the CLI into the Scribe-Data/tests directory such that they're ran as a part of the pytest suite?

I will work on it.

[andrewtavis]

@mhmohona, just updated both your branches as there have been tons of changes recently. Let us know if there's anything we can do to support with these!

[mhmohona]

@andrewtavis @wkyoshida this PR is up for review now.

[andrewtavis]

Maybe one day could be a language 😅 Wikidata does have data for it 😇 But fine for now :)

[andrewtavis]

Thanks for writing all of these tests, @mhmohona! Great that the Scribe community is focussing so much more on tests these days 😊

[wkyoshida]

Hmm - just noting something down here that came to mind just now..

Concerning the discussion we had on providing package options without PyICU and consequently the emoji functionality - omitting emoji-keywords as an available data type in the command output will probably be a good idea. With that, testing that the appropriate options are getting outputted given whether with/without PyICU might be good too.

...but! That's for when we get there 😉