bug: single quote(') in commit_message would lead to failure #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamranf
force-pushed
the
kamranf/fix-error-when-quote-in-message
branch
from
3e00998
to
1348c81
Compare
terranisu
reviewed
Sep 18, 2024
kamranf
force-pushed
the
kamranf/fix-error-when-quote-in-message
branch
from
1348c81
to
a41018b
Compare
helenff
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per here, if commit message contains
', notification fails due to bash error:Workaround would be to store and pass the commit_message and custom_message as an environment variable instead of github action in-place substitution (via
${{ }}).Testing: per #test-release-notification confirmed notification work as expected:
