Remove RCL check from .build() #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As there is a check made when the ConstructionSite is first places, and further checks to avoid excess completed Structures from being used in the case of RCL drops, preventing all ConstructionSites of a given type from being completed (not built, just completed) if the RCL drops for some reason appears redundant. So, let's remove the checkControllerAvailability-related check that can return ERR_RCL_NOT_ENOUGH entirely.
As there is a check made when the ConstructionSite is first places, and further checks to avoid excess completed Structures from being used in the case of RCL drops, preventing all ConstructionSites of a given type from being completed (not built, just completed) if the RCL drops for some reason appears redundant. So, let's remove the checkControllerAvailability-related check that can return ERR_RCL_NOT_ENOUGH entirely.
RiftLurker
approved these changes
Feb 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As there is a check made when the ConstructionSite is first places, and further checks to avoid excess completed Structures from being used in the case of RCL drops, preventing all ConstructionSites of a given type from being completed (not built, just completed) if the RCL drops for some reason appears redundant.
So, let's remove the checkControllerAvailability-related check that can return ERR_RCL_NOT_ENOUGH entirely. This doesn't speed anything up or provide any advantages to construction as the placeConstructionSite call and individual buildings which scale with RCL both use checkControllerAvailability, but this patch does remove a hard-to-understand error condition.
This resolves issue #59, where the following sequence of events can occur currently: