Calculate CPU usage outside of the player's isolate. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would argue that calculating it outside the isolate would be far less precise since it's not an immediate calculation of userspace code execution, it will always charge the player some additional amount of CPU. Do you have any particular exploit in mind regarding this? |
RiftLurker
reviewed
Sep 9, 2019
|
|
||
| run.dispose(); | ||
| dataRef.dispose(); | ||
|
|
||
| let intentCount = countIntents(runResult.intents); | ||
| runResult.intentsCpu = intentCount / 0.2; |
There was a problem hiding this comment.
This is equal to a multiply with 5 (intentCount * 5) which doesn't seem intended.
Suggested change
| runResult.intentsCpu = intentCount / 0.2; | |
| runResult.intentsCpu = intentCount * 0.2; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves cpu usage tracking outside of the player's isolate. Within the isolate it's possible for a player to alter the calculation in their favor.