Inspector config hooks #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you seen this race condition ever happening? It should never be the case, since the same user is not supposed to be executed in two threads simultaneously. |
|
It happened for the source keepers, flooded the logs until I put the promise workaround in place. |
|
Looks like this patch needs to be rebased |
|
Merged to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote a mod that enables the v8 inspector in isolates but I needed some config hooks to get it done.
There's another change to
createas well.. There was a race condition here if that function was called more than once before the first one was done completing. This would end up creating multiple isolates for the same user before the first one was initialized. So instead if you call the function more than once it will just return a promise to the previous not yet initialized isolate.The mod is here: https://github.com/laverdet/screepsmod-inspector