Terminate path finding if execution times out #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was thinking about it and it's possible a user could misuse the path finder to raise that assertion error you were seeing. isolated-vm will wait for up to 200ms after requesting v8 to terminate the isolate before it raises that error. It seems like a pretty good amount because v8 should in theory terminate execution immediately. The path finder currently doesn't check that flag, but it should. If the user set
opsvery high while requesting an impossible path or was doing recursive path finder operations from theirroomCallbackI think they might be able to cause the error.