Correct overwriting of config.engine #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an issue in the runtime where `config.engine` gets overwritten with an empty EventEmitter. This causes `config.engine` to be empty for mods and prevents events like `onPlayerSandbox` from working. This patch fixes the runtime so that `config.engine` is not overwritten.
|
This bug is preventing several pretty interesting mods from being developed. |
|
Bump- we've got broken community mods that are waiting on this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue in the runtime where
config.enginegets overwritten with an empty EventEmitter. This causesconfig.engineto be empty for mods and prevents events likeonPlayerSandboxfrom working.This patch fixes the runtime so that
config.engineis not overwritten.