Add RANGE_* constants #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastianh
suggested changes
Jun 19, 2017
lib/constants.js
Outdated
| RANGE_BUILD: 3, | ||
| RANGE_CLAIM_CONTROLLER: 1, | ||
| RANGE_DISMANTLE: 1, | ||
| RANGE_DROP: 1, |
There was a problem hiding this comment.
RANGE_DROP: I don't think this is used anywhere .. and I think it's not quite correct :)
There was a problem hiding this comment.
I agree, RANGE_DROP seems weird. You can not give a position to where you'd want to drop resources.
There was a problem hiding this comment.
It's possible that I just mindlessly added RANGE_ constants for all of the actions, it obviously doesn't make any sense for drop.
I'll update the PR later on.
semperrabbit
added a commit
to semperrabbit/screeps_common
that referenced
this pull request
Jul 16, 2019
PR screeps#2 to screeps/common clone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These constants are used for every kind of intents that are limited by range, the implementation is added with PR#6 in screeps/engine.
The constants OBSERVER_RANGE and NUKE_RANGE are not included as these are used separately and I'm not sure how this will work when changing those e.g. by server-mods.