Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat!: Remove prototype access to instance interfaces #274

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DiamondMofeng
Copy link
Member

@DiamondMofeng DiamondMofeng commented Feb 2, 2025

In the javascript world, prototype can only be accessed from constructors. Adding prototype to these interfaces is invalid and wrong

Anyway, this may break something. Please merge this PR only if we are about to release a major update.

Checklists

  • Test passed
  • Coding style (indentation, etc)
  • Edits have been made to src/ files not index.d.ts
  • Run npm run compile to update index.d.ts

In the javascript world, `prototype` can only be accessed from constructors.
@tiennou
Copy link
Contributor

tiennou commented Feb 2, 2025

For the record, not seeing any breakage from that here, and that's ~120 prototyped functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants