Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type Mineral.density #268

Merged
merged 1 commit into from
Feb 2, 2025
Merged

Type Mineral.density #268

merged 1 commit into from
Feb 2, 2025

Conversation

tiennou
Copy link
Contributor

@tiennou tiennou commented Feb 2, 2025

Brief Description

Add proper types to the DENSITY_* constants, and type MineralDensity with that.

Checklists

  • Test passed
  • Coding style (indentation, etc)
  • Edits have been made to src/ files not index.d.ts
  • Run npm run compile to update index.d.ts

@tiennou tiennou force-pushed the fix/mineral-density branch from aa083f7 to 020e58b Compare February 2, 2025 12:32
DiamondMofeng
DiamondMofeng approved these changes Feb 2, 2025
View reviewed changes
Copy link
Member

@DiamondMofeng DiamondMofeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DiamondMofeng DiamondMofeng merged commit ec6110c into screepers:master Feb 2, 2025
3 checks passed
@tiennou tiennou deleted the fix/mineral-density branch February 2, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiamondMofeng DiamondMofeng DiamondMofeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiennou @DiamondMofeng