Call into V2SVGAdapter instead of SVGRenderer #2800
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on scratchfoundation/scratch-svg-renderer#213 and scratchfoundation/scratch-gui#6547
Resolves
Resolves scratchfoundation/scratch-svg-renderer#211
Proposed Changes
This PR changes the costume loading API to use the new
V2SVGAdapter
API (a function) instead of theSvgRenderer
API (a class).Reason for Changes
By depending only on the parts of the SVG renderer API that are actually used here, this will allow the monolithic
SvgRenderer
class to be removed.Test Coverage
Tested manually