GHA workflow

[skripted-io]

I used @cwillisf GHA template for scratch-vm as a basis.

Additions/changes:

• A release version ID is generated in the form of "0.2.0-prerelease.20230929153610"
• Instead of "npx --no -- semantic-release" we are using "npm publish --tag $NPM_TAG"
• The current commit is tagged with the release version after successful publish

That last bit wasn't tested, because npm publish has a --dry-run flag which can be removed once this code is approved. If the tagging then fails I need to look at that again. fixed with a condition.

[cwillisf]

Great progress! I see a few important differences compared to the CCI config.

[cwillisf]

This repo doesn't need this workflow since it doesn't have any localized UI

[skripted-io]

Got it. Thnx!

[cwillisf]

Good idea! I'll add this in some of my work...

[cwillisf]

Looks like this is missing the hotfix handling from the CircleCI config:

scratch-svg-renderer/.circleci/config.yml

Lines 42 to 59 in 0705358

	name: Setup Deploy
	command: |
	export NODE_ENV=production
	export RELEASE_TIMESTAMP=$(date +'%Y%m%d%H%M%S')
	echo "export NPM_TAG=latest" >> $BASH_ENV
	npm run build
	if [ -z "$BEFORE_DEPLOY_RAN" ]; then
	VPKG=$($(npm bin)/json -f package.json version)
	VERSION=${VPKG}-prerelease.${RELEASE_TIMESTAMP}
	echo "export RELEASE_VERSION=${VERSION}" >> $BASH_ENV
	npm --no-git-tag-version version $VERSION
	if [[ "$CIRCLE_BRANCH" == hotfix/* ]]; then # double brackets are important for matching the wildcard
	echo "export NPM_TAG=hotfix" >> $BASH_ENV
	fi
	git config --global user.email "$(git log --pretty=format:"%ae" -n1)"
	git config --global user.name "$(git log --pretty=format:"%an" -n1)"
	echo "export BEFORE_DEPLOY_RAN=true" >> $BASH_ENV
	fi

Sorry this is so inconsistent between repositories, but this repo in particular has been a source of hotfixes in the past so I think it's important to retain that support

[skripted-io]

Thanks, yeah I think I ignored it for convenience :-D
on it!

[cwillisf]

Thanks for moving to npm ci and adding a package lockfile! 😎

[cwillisf]

Oh, right... looks like the commitlint step is complaining about the commit messages not following conventional commits. Most of the front-end & editor repositories use that format now.

[cwillisf]

Sorry, I had this review pending and forgot to submit it.
This looks like it'll work! Thanks :)

[cwillisf]

Ah, that makes sense. Thanks!

[apple502j]

The branch is actually called "master" here.