Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up the SvgRenderer monolith #211

Closed
adroitwhiz opened this issue Jan 7, 2021 · 1 comment · Fixed by #213
Closed

Split up the SvgRenderer monolith #211

adroitwhiz opened this issue Jan 7, 2021 · 1 comment · Fixed by #213
Assignees

Comments

@adroitwhiz
Copy link
Contributor

adroitwhiz commented Jan 7, 2021

Expected Behavior

SVG renderer functionality should be exported in a granular way, so each place that depends on it can take only what it needs (e.g. 2.0 -> 3.0 SVG conversion, measuring SVGs, deserializing SVGs, actually drawing SVGs). This is blocking scratchfoundation/scratch-render#594.

Actual Behavior

Currently there's lots of functionality mixed into SvgRenderer, some of which is used in scratch-render, some of which is used in scratch-vm, etc. This should all be separated out, especially since #127 will be adding lots of scratch-render-specific SVG rendering code, and it would be cleaner for that to be able to live in scratch-render.

@fsih
Copy link
Contributor

fsih commented Feb 4, 2021

This looks like a really good improvement! It could also be a really helpful step towards some of our other SVG issues. I'm going to talk to our tech lead about it to make sure it's ok, and then we'll start looking at putting this in.

@fsih fsih self-assigned this Feb 4, 2021
@fsih fsih closed this as completed in #213 Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment