Also initialize the shared audio context on keydown #8570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntext this fixes a crash when navigating to the Sounds tab without clicking or tapping
cwillisf
added
Low Impact
High Severity
accessibility
priority 2
and removed
priority 3
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Proposed Changes
Adds an additional event listener in
src/lib/audio/shared-audio-context.jswhich listens forkeydownevents. This fixes a crash that happens if you use only Tab and the arrow keys to go to the Sounds tab without clicking.Reason for Changes
Fixes a bug, and because:
Test Coverage
Did not add any tests.
Browser Coverage
Mac
Windows
Chromebook
iPad
Android Tablet