Skip to content

CE-142 Fix to hold jpg on the backpack #7757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

yokobond
Copy link

Resolves

Proposed Changes

This patch adds switch-case selection for 'image/jpg' in the backpack payload function.

Reason for Changes

If the "image/jpg" case is missing, mime and body of the payload will not be set.

Test Coverage

It's tested by hand.

Browser Coverage

Check the OS/browser combinations tested (At least 2)

Mac

  • Chrome
  • Firefox
  • Safari

Windows

  • Chrome
  • Firefox
  • Edge

Chromebook

  • Chrome

iPad

  • Safari

Android Tablet

  • Chrome

@rschamp rschamp requested a review from seotts January 31, 2022 19:26
@seotts seotts removed their assignment Jun 8, 2022
@seotts seotts removed their request for review June 8, 2022 14:14
@benjiwheeler benjiwheeler changed the title Fix to hold jpg on the backpack CE-142 Fix to hold jpg on the backpack Aug 2, 2022
@yokobond yokobond force-pushed the fix/backpack_jpg branch from 3825abd to ea1585c Compare May 1, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CE-142, CE-135 JPEG images cannot be backpacked
4 participants