add support for python 3.12 #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gallaecio
reviewed
Dec 1, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #434 +/- ##
==========================================
+ Coverage 89.47% 89.49% +0.02%
==========================================
Files 34 34
Lines 2432 2438 +6
==========================================
+ Hits 2176 2182 +6
Misses 256 256 ☔ View full report in Codecov by Sentry. |
Gallaecio
reviewed
Dec 18, 2023
|
cc @wRAR |
wRAR
reviewed
Dec 25, 2023
| cmd[-1] += '; sys.exit(99)' | ||
| utils.run_cmd(cmd) | ||
|
|
||
| def test_pwd_git_version_without_git(self): | ||
| # Change into test dir to make sure we're within a repo | ||
| os.chdir(os.path.dirname(__file__)) | ||
| self.assertIsNotNone(utils.pwd_git_version()) | ||
| with patch('shub.utils.find_executable', return_value=None): | ||
| with patch('shub.utils.which', return_value=None): |
There was a problem hiding this comment.
Should this be shub.utils.which or shutil.which?
There was a problem hiding this comment.
This confused me at first too, but because shub.utils is already imported before applying the patch we have to use the same object name that pwd_git_version refers to (other tests also do this, see @patch('shub.utils.time.time') right below)
Gallaecio
reviewed
Dec 28, 2023
Comment on lines
+278
to
+280
| self.assertLessEqual( | ||
| {'key': 'value'}.items(), | ||
| utils.latest_github_release(cache='./cache.txt').items(), |
Gallaecio
reviewed
Dec 28, 2023
Gallaecio
approved these changes
Dec 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Python 3.12. Main changes:
NamedTemporaryFileno longer has adeleteattribute, presumably this wasn't part of the public API: python/cpython@743453a#diff-6553a99f3ae04c9fc9c2349ac27037bfe3b274d5ca54d5800d9c5b5f11e29d21L470 (refactored to not rely on it)distutilswas removed (replaced version classes with equivalent one frompackaging)pkg_resourcesis no longer provided by default (was also deprecated, so replaced it withimportlib.metadata)configparser.SafeConfigParserwas removed in favor ofConfigParser