Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding supports of job resource filters when access hubstorage #372

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

starrify
Copy link
Member

@starrify starrify commented Oct 4, 2019

Implements #297

@codecov
Copy link

codecov bot commented Oct 4, 2019

Codecov Report

Merging #372 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #372      +/-   ##
==========================================
+ Coverage   91.49%   91.51%   +0.02%     
==========================================
  Files          34       34              
  Lines        2362     2369       +7     
==========================================
+ Hits         2161     2168       +7     
  Misses        201      201
Impacted Files Coverage Δ
shub/requests.py 100% <100%> (ø) ⬆️
shub/items.py 100% <100%> (ø) ⬆️
shub/utils.py 90.49% <100%> (+0.05%) ⬆️
shub/log.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2871384...d5ad34c. Read the comment docs.

@starrify starrify mentioned this pull request Oct 4, 2019
@starrify
Copy link
Member Author

CI failed for 469b2cf:

However the errors seem to be unrelated to changes in this PR. 🤔

@starrify
Copy link
Member Author

Merged #376 to resolve multiple CI errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant