Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes related to upcoming scrapy-zyte-api request fingerprinting work #185

Merged
merged 4 commits into from
Jan 24, 2024

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Jan 23, 2024

Required by scrapy-plugins/scrapy-zyte-api#165.

To do:

  • Tests.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Merging #185 (f5300a9) into master (3b2a0f7) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
+ Coverage   86.83%   86.88%   +0.05%     
==========================================
  Files          15       15              
  Lines         896      900       +4     
==========================================
+ Hits          778      782       +4     
  Misses        118      118              
Files Coverage Δ
scrapy_poet/_request_fingerprinter.py 100.00% <100.00%> (ø)
scrapy_poet/utils/testing.py 80.00% <100.00%> (+0.13%) ⬆️

@Gallaecio Gallaecio marked this pull request as ready for review January 24, 2024 11:57
@Gallaecio Gallaecio requested review from kmike, wRAR and BurnzZ January 24, 2024 11:57
@Gallaecio Gallaecio merged commit 13280a0 into scrapinghub:master Jan 24, 2024
15 checks passed
@BurnzZ
Copy link
Contributor

BurnzZ commented Jan 24, 2024

Sorry, I had this PR opened but wanted to approve a different one 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants